Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the uncaught typeerror when el is null #1308

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

sy-records
Copy link
Member

@sy-records sy-records commented Jul 26, 2020

Summary

fix: the uncaught typeerror when el is null. close #1154

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@vercel
Copy link

vercel bot commented Jul 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/54s38yzc4
✅ Preview: https://docsify-preview-git-fork-sy-records-fix-1154.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 26, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bf20ea1:

Sandbox Source
docsify-template Configuration

Copy link
Member

@anikethsaha anikethsaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
[non blocking suggestion]: can we have a test for this?

Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO,Idk why the dark theme buttom changes would break the router changes.
is that issue reproducible ? and can u give more details about the fix change.

@sy-records
Copy link
Member Author

Actually, it's a problem with @jerryc127 code.

document.querySelector("#dark_to_light").innerHTML

use innerHTML can't get the parentNode.

@Koooooo-7
Copy link
Member

Koooooo-7 commented Jul 27, 2020

Actually, it's a problem with @jerryc127 code.

document.querySelector("#dark_to_light").innerHTML

use innerHTML can't get the parentNode.

About this kind of fixing, I have reservations.
Although, adding an element undefined/null checking is okay.
we don't need fix issue is not our side.
besides that, sometimes, exception is necessary for troubleshooting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read property 'tagName' of null
3 participants